> -----Original Message-----
> From: Tomas Hozza [mailto:tho...@redhat.com]
> Sent: Wednesday, May 22, 2013 8:55 AM
> To: gre...@linuxfoundation.org
> Cc: KY Srinivasan; jasow...@redhat.com; Haiyang Zhang;
> devel@linuxdriverproject.org; Tomas Hozza
> Subject: [PATCH v3 1/4] tools: hv: Check return value of setsockopt call
> 
> Check return value of setsockopt call and if it fails print error
> to the system log and exit with non-zero value.
> 
> Signed-off-by: Tomas Hozza <tho...@redhat.com>

Acked-by: K. Y. Srinivasan <k...@microsoft.com>
> ---
>  tools/hv/hv_kvp_daemon.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 5a1f648..ae9aa1c 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1457,7 +1457,13 @@ int main(void)
>               exit(EXIT_FAILURE);
>       }
>       nl_group = CN_KVP_IDX;
> -     setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &nl_group,
> sizeof(nl_group));
> +
> +     if (setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP,
> &nl_group, sizeof(nl_group)) < 0) {
> +             syslog(LOG_ERR, "setsockopt failed; error: %d %s", errno,
> strerror(errno));
> +             close(fd);
> +             exit(EXIT_FAILURE);
> +     }
> +
>       /*
>        * Register ourselves with the kernel.
>        */
> --
> 1.8.1.4
> 
> 


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to