Type of variable 'bi' is struct comedi_bufinfo and 'subdevice' is
defined as unsigned, so there is no need to check if it is less then
zero.

Signed-off-by: Güngör Erseymen <gelur...@gmail.com>
---
 drivers/staging/comedi/comedi_fops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_fops.c 
b/drivers/staging/comedi/comedi_fops.c
index 986f195..c561a0e 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -913,7 +913,7 @@ static int do_bufinfo_ioctl(struct comedi_device *dev,
        if (copy_from_user(&bi, arg, sizeof(bi)))
                return -EFAULT;
 
-       if (bi.subdevice >= dev->n_subdevices || bi.subdevice < 0)
+       if (bi.subdevice >= dev->n_subdevices)
                return -EINVAL;
 
        s = &dev->subdevices[bi.subdevice];
-- 
1.8.3

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to