On Tue, Feb 4, 2025 at 5:21 PM <devel-requ...@lists.crash-utility.osci.io> wrote:
> Date: Tue, 4 Feb 2025 22:18:09 +1300 > From: Tao Liu <l...@redhat.com> > Subject: [Crash-utility] [PATCH 0/5] Update to gdb-16.2 > To: devel@lists.crash-utility.osci.io > Cc: Tao Liu <l...@redhat.com> > Message-ID: <20250204091845.757887-1-l...@redhat.com> > Content-Type: text/plain; charset=UTF-8 > > Actually this patchset is a combination of "Update to gdb-16.2" and > "Fix several build failures". > > The reason for the patchset combination is, the latter one backported > several gdb upstream patches[1], which is not needed after the gdb upgrade. > It is meaningless to backport and revert the patch in a short time, so I > merged them into 1 patchset. > > For patchset "Fix several build failures", patch 1 is elimited, patch 2 > is untouched, and patch 3 is slightly modified for adaption. > > [1]: > https://www.mail-archive.com/devel@lists.crash-utility.osci.io/msg01331.html > > Lianbo Jiang (2): > tools.c: do not use keywords 'nullptr' as a variable in code > Fix build failure on 32bit machine(i686) > > Tao Liu (3): > Revert: Fix C99 compatibility issues in embedded copy of GDB Revert longaarch related gdb changes > As you mentioned in patch log, the above two patches are no longer needed, which are included in gdb 16.2. So I would suggest removing them from gdb-16.2.patch, revert is not very good in the gdb upgrade case. For LoongArch, also remove crash part changes(it may not work), once the gdb-16.2 upgrade is ready, the LoongArch people can follow the current changes and get a clean patch, maybe two or three hundred lines of code. Update to gdb-16.2 > I tend to have a clean patch for gdb-16.2 rather than based on gdb-10.2.patch, and which is easier to maintain in the future. BTW: for several build failure patches, I would suggest handling them firstly. If we can not merge the gdb-16.2 patch in time, there may be risks. What do you think? Thanks Lianbo > Makefile | 3 + > configure.c | 21 +- > crash_target.c | 6 +- > defs.h | 8 +- > gdb-10.2.patch | 16241 ---------------------------------------------- > gdb-16.2.patch | 2258 +++++++ > gdb_interface.c | 18 +- > kernel.c | 6 +- > symbols.c | 4 +- > tools.c | 6 +- > 10 files changed, 2304 insertions(+), 16267 deletions(-) > delete mode 100644 gdb-10.2.patch > create mode 100644 gdb-16.2.patch > > -- > 2.47.0 >
-- Crash-utility mailing list -- devel@lists.crash-utility.osci.io To unsubscribe send an email to devel-le...@lists.crash-utility.osci.io https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/ Contribution Guidelines: https://github.com/crash-utility/crash/wiki
