On Tue, Oct 7, 2025 at 7:37 PM <[email protected]>
wrote:

> Date: Tue,  7 Oct 2025 16:52:40 +1300
> From: Tao Liu <[email protected]>
> Subject: [Crash-utility] [PATCH] Fix the misleading uncompress error
>         message
> To: [email protected]
> Cc: Tao Liu <[email protected]>
> Message-ID: <[email protected]>
> Content-Type: text/plain; charset="US-ASCII"; x-default=true
>
> The "unxz" is missing for uncompressing fail message. Fix [1].
>
> [1]: https://github.com/crash-utility/crash/issues/220


Can you add the Resolves tag before Sob, E.g:

Resolves:  https://github.com/crash-utility/crash/issues/220
Signed-off-by: Tao Liu <[email protected]>

And this looks good to me: Ack.

Thanks
Lianbo


>
> Signed-off-by: Tao Liu <[email protected]>
> ---
>  symbols.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/symbols.c b/symbols.c
> index ee3cba1..e6af38b 100644
> --- a/symbols.c
> +++ b/symbols.c
> @@ -4481,8 +4481,9 @@ is_compressed_kernel(char *file, char **tmp)
>         }
>         if (system(command) < 0) {
>                 please_wait_done();
> -               error(INFO, "%s of %s failed\n",
> -                       type == GZIP ? "gunzip" : "bunzip2", file);
> +               error(INFO, "%s of %s failed\n",
> +                       type == GZIP ? "gunzip" :
> +                               (type == BZIP2 ? "bunzip2" : "unxz"),
> file);
>                 free(tempname);
>                 return FALSE;
>         }
> --
> 2.47.0
>
--
Crash-utility mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki

Reply via email to