Hi, Mikhail
Thank you for the patch.
For the [patch 1] and [patch 2], there are many warnings:
$make warn
...
s390x.c: In function ‘show_trace’:
s390x.c:1747:79: warning: format ‘%llx’ expects argument of type ‘long long
unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
1747 | fprintf(fp, " USER-MODE INTERRUPT
FRAME at %llx\n", iframe_addr);
|
~~~^ ~~~~~~~~~~~
|
| |
|
| long unsigned int
|
long long unsigned int
|
%lx
s390x.c:1749:45: warning: too many arguments for format
[-Wformat-extra-args]
1749 | fprintf(fp, " USER-MODE INTERRUPT
FRAME;", sp);
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390x.c:1750:53: warning: format ‘%llx’ expects argument of type ‘long long
unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
1750 | fprintf(fp, " pt_regs at %llx:\n", sp);
| ~~~^ ~~
| | |
| | long
unsigned int
| long long
unsigned int
| %lx
s390x.c:1764:73: warning: format ‘%llx’ expects argument of type ‘long long
unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
1764 | fprintf(fp, " KERNEL-MODE INTERRUPT FRAME
at %llx\n", iframe_addr);
|
~~~^ ~~~~~~~~~~~
|
| |
|
| long unsigned int
|
long long unsigned int
|
%lx
s390x.c:1766:37: warning: too many arguments for format
[-Wformat-extra-args]
1766 | fprintf(fp, " KERNEL-MODE INTERRUPT
FRAME;", sp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390x.c:1767:45: warning: format ‘%llx’ expects argument of type ‘long long
unsigned int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
1767 | fprintf(fp, " pt_regs at %llx:\n", sp);
| ~~~^ ~~
| | |
| | long unsigned int
| long long unsigned int
| %lx
s390x.c: In function ‘s390x_eframe_search’:
s390x.c:1390:1: warning: control reaches end of non-void function
[-Wreturn-type]
1390 | }
| ^
Can you help double check? And the output via bt command is not expected,
E.g:
crash> bt
PID: 13982 TASK: 861ec200 CPU: 3 COMMAND: "bash"
LOWCORE INFO:
...
USER-MODE INTERRUPT FRAME; pt_regs at 2f9d6da3f38:
...
But, the feature looks fine to me.
Thanks
Lianbo
On Wed, Nov 5, 2025 at 5:30 PM Mikhail Zaslonko <[email protected]>
wrote:
> Expand s390x 'bt' output.
> Add basic 'bt -e' support for s390x.
>
> Mikhail Zaslonko (2):
> s390x: Expand bt output with PSW mode and pt_regs address
> s390x: Add basic 'bt -e' support for s390x
>
> s390x.c | 44 ++++++++++++++++++++++++++++++++------------
> 1 file changed, 32 insertions(+), 12 deletions(-)
>
> --
> 2.49.0
>
>
--
Crash-utility mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
