On lundi 12 novembre 2018 18:10:47 CET Daiki Ueno wrote:
> Tom Hughes <t...@compton.nu> writes:
>
>
> > If it's going to one source rpm producing the same three binary
> > rpms then you are indeed correct.
>
>
> Thank you for the suggestions. Then I will go ahead and retire nss-util
> and nss-softokn source packages once we are sure that the generated
> binary packages are sane enough. I have created a copr repository for
> testing:
> https://copr.fedorainfracloud.org/coprs/ueno/nss-consolidate/
>
> firefox and java-openjdk maintainers: could you check if these builds
> don't break anything?
>
> Regards,
> --
> Daiki Ueno
Could we also remove the old cruft?
- Group: is not needed.
- %{__rm} -rf $RPM_BUILD_ROOT is not needed in %install
- Using %{__rm}, %{__mkdir_p}, %{__install}, %{__cp}, %{__make} and so on is
pointless, just use the binaries directly.
- %ldconfig_scriptlets: You can drop this now (since F28).
- The man files should not be marked as %doc and %attr(0644,root,root) should
not be needed as it is the default:
%attr(0644,root,root) %doc %{_mandir}*
- The extension of the man pages .gz should be globbed instead as we may
change the compression in the future.
- Your Requires: in devel subpackages are missing %{?_isa}
Requires: nss%{?_isa} = %{version}-%{release}
Requires: nss-util%{?_isa} = %{version}-%{release}
- Consider using a URL for Source0:
Source0: https://hg.mozilla.org/projects/nss/archive/%
{nss_tag}.tar.gz
with %global nss_tag NSS_3_40_RTM
instead of Source0: %{name}-%{nss_archive_version}.tar.gz
You may need to adjust %prep:
%setup -q -n nss-%{nss_tag}
and -p1 the patches instead of -p0/-p1
and remove the ./nss/ top directory from various commands in %build and
%install to match the archive structure.
See my SPEC at https://copr-be.cloud.fedoraproject.org/results/eclipseo/
firefox-nightly/fedora-rawhide-x86_64/00826328-nss/nss.spec
Build: https://copr.fedorainfracloud.org/coprs/eclipseo/firefox-nightly/build/
826328/
Please consider these changes for your PR.
Best regards,
Robert-André
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
