Hi Pavol,
I can not approve your package, but I would suggest some things.
* Bump your rev version. Incl. changelog.
* Define your BuildRoot
* Use %{_bindir} instead of /usr/bin
* Source-format your spec-file
Why do you have:
%if 0%{?rhel} && 0%{?rhel} <= 5
rm -rf %{buildroot}
%endif
Why not just:
rm -rf $RPM_BUILD_ROOT
Nice page: https://fedoraproject.org/wiki/Packaging:RPMMacros
Anyways :)
David
*David Roheim*
david.roh...@gmail.com - http://roheim.org/
On Tue, Feb 18, 2014 at 9:41 PM, Pavol Ipoth <pavol.ip...@gmail.com> wrote:
> Hi,
>
> can please somebody approve my package, it was already reviewed but
> reviewer doesn't have permissions to approve new package. Can somebody look
> at it. Thanks.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1058038
>
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
> Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
>
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
