On Tue, 2008-05-13 at 16:15 -0700, Andrew Morton wrote: > On Tue, 13 May 2008 19:12:27 -0400 Andres Salomon <[EMAIL PROTECTED]> wrote: > > > And FWIW, I like the 80 char limit _except_ when it comes to strings. > > I don't normally bother about the strings, unless it is obvious that > the surrounding code has worked to prevent them from wrapping (and if I > notice that). > > Or if they make code particularly hard to read and alter. I've seen > some which wander out to column 130, which is getting daft. > > The code at http://userweb.kernel.org/~akpm/x.jpg has short strings, > but it has gone and stuffed the _arguments_ onto the same line too, which > is just obnoxious.
I would probably accept patches to move the arguments onto the next line; I don't think that would make the overall code less readable. In fact, I would normally put the arguments on the next line these days anyway -- but that particular piece of debugging code dates from before all this pointless fuss about 80 columns got started, so it was never an issue. It could probably do with printk priorities too, while we're at it. -- dwmw2 _______________________________________________ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel
