daniel wrote: > Hi Paul, > > I've made some small changes to your code for the XO-1.5 ebook switch > driver and am wondering if you have any comments before I submit this > upstream.
this looks great. thanks again for taking this on. i haven't yet had a chance to do a close review (will do tom'w), but assuming the details are right, just a couple of initial comments... > > - driver renamed to "xo1p5-ebook" like chris, i don't think this is a great name. we already use at least two naming styles (olpc_dcon_xo_1_5.c, olpc-pm-1.5.c) and introducing a third doesn't seem great. frankly, i think "xo15", "xo175", etc, would be sufficient, since the lack of a decimal is unlikely to lead to ambiguity, but barring that, i'd stick with using '_'. (of course, if dcon hasn't gone upstream yet (i don't recall), then now would be the time to change it too, if we want to change.) > - THRM# bit handling removed, since we'll do that in the DSDT > (pending Mitch's approval) whether or not we eventually decide to apply your DSDT patch, i think we'll probably want to leave the in-kernel bit twiddling in place for at least until the new firmware is available. and i guess i'm assuming that we wouldn't do new firmware just for this, but would wait until some more compelling reason came along. paul > - /proc interface removed > - /sys interface added (much simpler) > - minor updates for new ACPI API > > powerd will need an update for the /sys change. I'll take this on when > the time comes. (all this is framed for post-F14 release) > > > > [PATCH] OLPC XO-1.5 ebook switch driver ... =--------------------- paul fox, p...@laptop.org _______________________________________________ Devel mailing list Devel@lists.laptop.org http://lists.laptop.org/listinfo/devel