On Tue, Mar 12, 2024 at 18:06:43 +0100, Jiri Denemark wrote:
> The function returns a list of explicitly mentioned features in the CPU
> definition.
> 
> Signed-off-by: Jiri Denemark <jdene...@redhat.com>
> ---
>  src/conf/cpu_conf.c      | 24 ++++++++++++++++++++++++
>  src/conf/cpu_conf.h      |  3 +++
>  src/libvirt_private.syms |  1 +
>  3 files changed, 28 insertions(+)
> 
> diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
> index 6e6e1b9a89..08f57a4df8 100644
> --- a/src/conf/cpu_conf.c
> +++ b/src/conf/cpu_conf.c
> @@ -982,6 +982,30 @@ virCPUDefFindFeature(const virCPUDef *def,
>  }
>  
>  
> +/**
> + * virCPUDefListFeatures:

Maybe ListExplicitFeatures?

> + * @def: CPU definition
> + *
> + * Provides a list of feature names explicitly mentioned in the CPU 
> definition

to make it clear to anyone who isn't looking at the definition of the
function?

> + * regardless on the policy. The caller is responsible for freeing the list.

s/on/of/

> + *
> + * Returns a NULL-terminated list of feature names.
> + */

Reviewed-by: Peter Krempa <pkre...@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org

Reply via email to