On Wed, Mar 20, 2024 at 01:10:00PM +0100, Peter Krempa wrote:
> On Wed, Mar 20, 2024 at 10:19:12 +0100, Andrea Bolognani wrote:
> > @@ -1355,7 +1363,7 @@ virSecurityManagerMetadataLock(virSecurityManager
> > *mgr G_GNUC_UNUSED,
> > }
> > #endif /* !WIN32 */
> >
> > - if (virFileIsSharedFS(p)) {
> > + if (virFileIsSharedFS(p, NULL)) {
>
> As virSecurityManagerMetadataLock is passed all of the functions that
> security labelling is happening on it feels weird to have one instance
> where it's not. Any reason you didn't pass it in? It should not matter
> as locally the files shouldn't return an error.
>
> If you have a reason, explain it in a comment please.
No reason at all, it was just an oversight O:-) Thanks a lot for
catching that! I've already fixed it locally.
--
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
