On Thu, Apr 18, 2024 at 13:00:48 +0200, Michal Privoznik wrote: > The purpose of ERROR() macro in our NSS module is to print error > message provided as arguments followed by error string > corresponding to errno. Historically, we've used strerror_r() for > that (please note, we want our NSS module to be free of libvirt > internal functions, or glib even - hence, g_strerror() is off the > table). > > Now strerror_r() is documented as: > > Returns ... a pointer to a string that the function stores in > buf, or a pointer to some (immutable) static string (in which > case buf is unused). > > Therefore, we can't rely the string being stored in the buf and > really need to store the retval and print that instead. > > While touching this area, decrease the ebuf size, since its > current size (1KiB) is triggering our stack limit (2KiB) in some > cases. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > ---
Reviewed-by: Peter Krempa <pkre...@redhat.com> _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
