On Fri, Jun 28, 2024 at 15:12:33 +0200, Michal Privoznik wrote:
> If mgmt apps on top of libvirt want to make a decision on the
> backend type for <interface type='user'/> (e.g. whether past is
> supported) we currently offer them no way to learn this fact.
> Domain capabilities were invented exactly for this reason. Report
> supported net backend types there.
> 
> Now, because of backwards compatibility, specifying no backend
> type (which translates to VIR_DOMAIN_NET_BACKEND_DEFAULT) means
> "use hyperviosr's builtin SLIRP". That behaviour can not be
> changed. But it may happen that the hypervisor has no support for
> SLIRP. So we have to report it.
> 
> Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
> ---
>  docs/formatdomaincaps.rst       | 25 +++++++++++++++++++++++++
>  src/conf/domain_capabilities.c  | 13 +++++++++++++
>  src/conf/domain_capabilities.h  |  8 ++++++++
>  src/conf/schemas/domaincaps.rng | 10 ++++++++++
>  4 files changed, 56 insertions(+)

Reviewed-by: Peter Krempa <pkre...@redhat.com>

Reply via email to