On Mon, Jul 08, 2024 at 14:52:51 +0200, Martin Kletzander wrote: > Similarly to commit 2482801608b8 we can safely ignore connectionId, > portId and portgroupId in both XML and VMX as they are only a blind > pass-through between XML and VMX and an ethernet without such parameters > was spotted in the wild. On top of that even our documentation says the > whole VMWare Distrubuted Switch configuration is a best-effort. > > Resolves: https://issues.redhat.com/browse/RHEL-46099 > > Signed-off-by: Martin Kletzander <[email protected]> > --- > src/conf/domain_conf.c | 11 ++++----- > src/conf/schemas/domaincommon.rng | 24 ++++++++++++------- > src/vmx/vmx.c | 24 ++++++++++++------- > ...-portid.vmx => ethernet-vds-no-params.vmx} | 2 -- > ...-portid.xml => ethernet-vds-no-params.xml} | 2 +- > 5 files changed, 37 insertions(+), 26 deletions(-) > rename tests/vmx2xmldata/{ethernet-vds-no-portid.vmx => > ethernet-vds-no-params.vmx} (76%) > rename tests/vmx2xmldata/{ethernet-vds-no-portid.xml => > ethernet-vds-no-params.xml} (82%)
Reviewed-by: Jiri Denemark <[email protected]>
