On Wed, Aug 28, 2024 at 01:49:22PM GMT, Kamil Szczęk wrote:
> Hi Andrea,
>
> I was actually working on the same thing today, but haven't gotten around to
> posting the patches yet.
> Do you think it would make sense to make this feature indeterminate for
> non-i8042 machines?
>
> Like so:
>
> static void
> virQEMUCapsFillDomainFeaturePS2Caps(virQEMUCaps *qemuCaps,
> virDomainCaps *domCaps)
> {
> if (!virQEMUCapsMachineSupportsI8042(qemuCaps, domCaps->machine,
> domCaps->arch))
> return;
>
> if (virQEMUCapsMachineSupportsI8042Toggle(qemuCaps, domCaps->machine,
> domCaps->arch))
> domCaps->features[VIR_DOMAIN_CAPS_FEATURE_PS2] =
> VIR_TRISTATE_BOOL_YES;
> else
> domCaps->features[VIR_DOMAIN_CAPS_FEATURE_PS2] = VIR_TRISTATE_BOOL_NO;
> }
I had something like that initially, but then I realized that it
doesn't really make sense. Reporting
<ps2 supported='no'/>
on e.g. aarch64 is entirely accurate after all.
--
Andrea Bolognani / Red Hat / Virtualization
