Re: [PATCH 4/8] network: Don't check if network is active in networkShutdownNetwork

[Laine Stump]

On 9/3/24 10:36 AM, Martin Kletzander wrote:

It skips the cleanup from networkStartNetwork and the only other path> already 
checks if the network is active or not.

Signed-off-by: Martin Kletzander <mklet...@redhat.com>

Reviewed-by: Laine Stump <la...@redhat.com>

---
  src/network/bridge_driver.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index d27a7e9b88c4..e507dcd4c5c9 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -2405,9 +2405,6 @@ networkShutdownNetwork(virNetworkDriverState *driver,

VIR_INFO("Shutting down network '%s'", def->name); - if (!virNetworkObjIsActive(obj))

-        return 0;
-
      stateFile = virNetworkConfigFile(cfg->stateDir, def->name);
      if (!stateFile)
          return -1;