On Mon, Nov 18, 2024 at 19:24:21 +0530, Harikumar R wrote: > From: Chun Feng Wu <danielw...@163.com> > > Test domain xml and status xml > > * Add tests for "throttlegroup" domain xml processing, including > groups referenced and not referenced by filters > * Add tests for "throttlefilter" domain xml processing, including > throttle group referenced by different disks > * Add negative test case to report error when iotune is configured > together with throttle filters > * Add tests for throttlefilter nodename parse and format for statusxml > (disk/privateData/nodenames/nodename with type='throttle-filter') > * Add iotune limited disk tests to make sure iotune refactory works > > Signed-off-by: Chun Feng Wu <danielw...@163.com> > ---
So you'll need to split this commit. The 'status XML' test should really be in a separate commit. > .../throttlefilter-in.xml | 392 ++++++++++++++++++ > .../throttlefilter-out.xml | 392 ++++++++++++++++++ > tests/qemuxmlactivetest.c | 1 + > .../throttlefilter-invalid.x86_64-latest.err | 1 + > .../throttlefilter-invalid.xml | 89 ++++ > .../throttlefilter.x86_64-latest.args | 55 +++ > .../throttlefilter.x86_64-latest.xml | 105 +++++ > tests/qemuxmlconfdata/throttlefilter.xml | 95 +++++ > tests/qemuxmlconftest.c | 2 + > 9 files changed, 1132 insertions(+) > create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-in.xml > create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-out.xml > create mode 100644 > tests/qemuxmlconfdata/throttlefilter-invalid.x86_64-latest.err > create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.xml > create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args > create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/throttlefilter.xml The tests themselves look good; so after you deal with properly adding the missing line which was breaking the test you can use: Reviewed-by: Peter Krempa <pkre...@redhat.com> for both.
