On Wed, Jan 31, 2024 at 17:14:28 +0100, Pavel Hrdina wrote:
> When snapshot is created with disk-only flag it is always external
> snapshot without memory state. Historically when there was not support
> to revert external snapshots this produced error message.
> 
>     error: Failed to revert snapshot s1
>     error: internal error: Invalid target domain state 'disk-snapshot'. 
> Refusing snapshot reversion
> 
> Now we can simply consider this as reverting to offline snapshot as the
> possible damage to file system is already done at the point of snapshot
> creation.
> 
> Resolves: https://issues.redhat.com/browse/RHEL-21549
> Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
> ---
>  src/qemu/qemu_snapshot.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

A thread on libvirt-users found this patch and noticed it wasn't pushed.

Reviewed-by: Peter Krempa <pkre...@redhat.com>

Reply via email to