Daniel P. Berrangé <berra...@redhat.com> writes:

>>  src/bhyve/bhyve_command.c | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>
> This should come with additions to bhyvexml2argvtest.c data
> files.

Done

>> +static int
>> +bhyveBuildHostdevArgStr(const virDomainDef *def, virCommand *cmd)
>> +{
>> +    size_t i;
>> +
>> +    for (i = 0; i < def->nhostdevs; i++) {
>> +        virDomainHostdevDef *hostdev = def->hostdevs[i];
>> +        virDomainHostdevSubsys *subsys = &hostdev->source.subsys;
>> +
>> +        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS ||
>> +            subsys->type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
>> +        {
>> +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>> +                           _("unsupported hostdev"));
>> +            return -1;
>> +        }
>
> We should probably be diagnosing this in bhyveDomainDeviceDefValidate
> so it gets reported to the user much earlier.

Done.

-- 
Alexander Shursha

Reply via email to