On Tue, Apr 15, 2025 at 04:13:08 -0400, Narayana Murty N wrote:
> Add POWER11 as a supported cpu model for ppc64.

uppercase

> 
> Signed-off-by: Narayana Murty N <nnmli...@linux.ibm.com>
> ---
>  src/cpu_map/index.xml                      | 1 +
>  src/cpu_map/meson.build                    | 1 +
>  src/cpu_map/ppc64_POWER11.xml              | 6 ++++++
>  tests/domaincapsdata/qemu_10.0.0.ppc64.xml | 1 +
>  4 files changed, 9 insertions(+)
>  create mode 100644 src/cpu_map/ppc64_POWER11.xml

The naming of the file isn't consistent with the CPU model name and
commit message.

Otherwise looks good.

> 
> diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml
> index 87db338cee..790c3b2f83 100644
> --- a/src/cpu_map/index.xml
> +++ b/src/cpu_map/index.xml
> @@ -181,6 +181,7 @@
>        <include filename='ppc64_POWER8.xml'/>
>        <include filename='ppc64_POWER9.xml'/>
>        <include filename='ppc64_POWER10.xml'/>
> +      <include filename='ppc64_POWER11.xml'/>

uppercase

>      </group>
>  
>      <group name='Freescale-based CPU models'>
> diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build
> index dee8441a13..abf9c21e4f 100644
> --- a/src/cpu_map/meson.build
> +++ b/src/cpu_map/meson.build
> @@ -17,6 +17,7 @@ cpumap_data = [
>    'arm_vendors.xml',
>    'index.xml',
>    'ppc64_POWER10.xml',
> +  'ppc64_POWER11.xml',

uppercase

>    'ppc64_POWER6.xml',
>    'ppc64_POWER7.xml',
>    'ppc64_POWER8.xml',
> diff --git a/src/cpu_map/ppc64_POWER11.xml b/src/cpu_map/ppc64_POWER11.xml
> new file mode 100644
> index 0000000000..d624043072
> --- /dev/null
> +++ b/src/cpu_map/ppc64_POWER11.xml
> @@ -0,0 +1,6 @@
> +<cpus>
> +  <model name='power11'>

lowercase

> +    <vendor name='IBM'/>
> +    <pvr value='0x00820000' mask='0xffff0000'/>
> +  </model>
> +</cpus>
> diff --git a/tests/domaincapsdata/qemu_10.0.0.ppc64.xml 
> b/tests/domaincapsdata/qemu_10.0.0.ppc64.xml
> index 3c864146eb..c449d96f86 100644
> --- a/tests/domaincapsdata/qemu_10.0.0.ppc64.xml
> +++ b/tests/domaincapsdata/qemu_10.0.0.ppc64.xml
> @@ -39,6 +39,7 @@
>        <model usable='unknown' vendor='IBM'>POWER7</model>
>        <model usable='unknown' vendor='IBM'>POWER8</model>
>        <model usable='unknown' vendor='IBM'>POWER9</model>
> +      <model usable='unknown' vendor='IBM'>power11</model>

lowercase

>      </mode>
>    </cpu>
>    <memoryBacking supported='yes'>
> -- 
> 2.48.1
> 


Since lowercase is the cpu name make sure to name the file the same way
and fix the commit message

Reply via email to