On Tue, Apr 29, 2025 at 12:14:11 +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé <berra...@redhat.com> > > Allow virCommand to find 'dmidecode' in $PATH. This command is only > usable when running privileged since it relies on reading from a > privileged kernel file. Thus we can assume both 'bin' and 'sbin' dirs > will be in $PATH and virFindFileInPath will do the right thing to > find it when called by virCommand.
This was copied from a previous commit message but makes no sense here. > > Gating the iscsi driver backend on a isciadm probe is likely to do > more harm than good as it needlessly disables the code if the dev > forgot to install iscsiadm at build time. As a Linux only command > it is simpler to gate the feature based on the platform choice and > allow missing binaries to be diagnose at runtime. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > meson.build | 5 ++-- > src/util/viriscsi.c | 55 ++++++++++++++++++++++---------------------- > tests/viriscsitest.c | 16 ++++++------- > 3 files changed, 37 insertions(+), 39 deletions(-) Reviewed-by: Peter Krempa <pkre...@redhat.com>
