On Fri, May 09, 2025 at 08:38:43 -0000, ray wang wrote: > > > > So here the 'serial' is declared as mandatory. It's optional in the XML > > parser/formatter and mandatory in the commandline formatter. With other > > devices it's optional so it's most likely going to need an <optional> > > block. > > > > This series is also completely lacking documentation > > (docs/formatdomain.rst) documenting bot the new controller and disk > > type. > As described earlier, the intention is for the serial field to be mandatory. > Perhaps the parser/formatter handling led to some confusion? Any suggestions > are very welcome. > I'll add documentation for it in docs/formatdomain.rst.
It was unclear due to the discrepancies in the code and the lacking documentation couldn't explain it. It's okay if you need to make it mandatory, in which case add a validation check (src/qemu/qemu_validate.c) reporting a user-friendly error.
