On 5/15/25 17:28, Peter Krempa via Devel wrote: > This series: > > 1) Fixes the regression in loading internal snapshots: > https://gitlab.com/libvirt/libvirt/-/issues/771 > > 2) Fixes bugs in cleanup paths of snapshot reversion where we'd keep an > inactive transient VM definition in the domain list (Noticed when > debugging the former issue) > > 3) Cleans up qemu commandline generator of unneeded arguments for > snapshot reversion after recent removal of old code > > 4) Renames the argument used to revert internal snapshots to something > more obvious. > > 5) Cleans some unneeded passing of the qemu driver struct > > Peter Krempa (17): > qemuProcessStartWithMemoryState: Don't setup qemu for incoming > migration when reverting internal snapshot > NEWS: Mention fix for internal snapshot reversion regression > qemuSnapshotRevertActive: Remove transient domain on failure > qemuSnapshotRevertInactive: Ensure all error paths handle transient > domains properly > qemuBuildCommandLine: Drop 'snapshot' argument > qemuProcessLaunch: Rename 'snapshot' to 'internalSnapshotRevert' > qemuProcessStart: Rename 'snapshot' to 'internalSnapshotRevert' > qemuProcessStartWithMemoryState: Rename 'snapshot' to > 'internalSnapshotRevert' > qemuExtDevicesCleanupHost: Use 'virQEMUDriverConfig' instead of > 'virQEMUDriver' > qemuCheckpointDiscardAllMetadata: Remove 'driver' argument > qemuSnapshotDiscardAllMetadata: Remove 'driver' argument > qemuDomainRemoveInactiveCommon: Remove 'driver' argument > qemuProcessStop: Drop 'driver' argument > qemuDomainRemoveInactiveLocked: Remove 'driver' argument > qemuProcessReconnect: Modernize local variable setup > qemuProcessReconnectData: Drop 'driver' struct and clean up > qemuDomainRemoveInactive: Remove 'driver' argument > > NEWS.rst | 10 ++++ > src/qemu/qemu_checkpoint.c | 5 +- > src/qemu/qemu_checkpoint.h | 3 +- > src/qemu/qemu_command.c | 5 +- > src/qemu/qemu_command.h | 1 - > src/qemu/qemu_domain.c | 25 +++++----- > src/qemu/qemu_domain.h | 6 +-- > src/qemu/qemu_driver.c | 46 ++++++++---------- > src/qemu/qemu_extdevice.c | 18 +++---- > src/qemu/qemu_extdevice.h | 4 +- > src/qemu/qemu_migration.c | 20 ++++---- > src/qemu/qemu_process.c | 98 +++++++++++++++++++------------------- > src/qemu/qemu_process.h | 7 ++- > src/qemu/qemu_saveimage.c | 2 +- > src/qemu/qemu_snapshot.c | 75 ++++++++++++++--------------- > src/qemu/qemu_snapshot.h | 3 +- > src/qemu/qemu_tpm.c | 14 ++---- > src/qemu/qemu_tpm.h | 4 +- > 18 files changed, 167 insertions(+), 179 deletions(-) >
Reviewed-by: Michal Privoznik <mpriv...@redhat.com> Michal
