On Fri, May 16, 2025 at 01:30:41PM +0200, Ján Tomko via Devel wrote:
> On a Wednesday in 2025, Fabio Estevam wrote:
> > The following build error is observed with DEBUG_BUILD = 1:
> >
>
> What exactly is DEBUG_BUILD? I can't find the variable anywhere.
>
> --buildtype debug is the default for meson
> with -Doptimization=g this should already be disabled since:
> commit 7253dda5178e0504a4f3ba859c96883aca6bec7d
> build-sys: drop -Winline when optimization=g
>
> > src/cpu/cpu_x86.c: In function 'cpuidSetLeaf4':
> > src/cpu/cpu_x86.c:2563:1: error: inlining failed in call to 'cpuidCall':
> > function not considered for inlining [-Werror=inline]
> > 2563 | cpuidCall(virCPUx86CPUID *cpuid)
> > | ^~~~~~~~~
> >
> > Remove the 'inline' specifier to avoid the problem.
> >
>
> Is there a point in having
> 1) -Winline
Well this caught this bogus use of "inline" in a source
file, but arguably we could do that in a syntax-check
too.
> 2) inline functions at all (outside of header files)?
No, IMHO, the only valid place to use 'inline' is for
the 'static inline' declaration of a function in a
header file. Anywhere else just let the compiler
optimization decide what to do - it knows the situation
far better that the author will.
>
> > Reported-by: Hongxu Jia <hongxu....@windriver.com>
> > Signed-off-by: Fabio Estevam <feste...@gmail.com>
> > ---
> > src/cpu/cpu_x86.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
> > index 213af67ea478..0f7eb8f48b35 100644
> > --- a/src/cpu/cpu_x86.c
> > +++ b/src/cpu/cpu_x86.c
> > @@ -2564,7 +2564,7 @@ virCPUx86DataCheckFeature(const virCPUData *data,
> >
> >
> > #if defined(__i386__) || defined(__x86_64__)
> > -static inline void
> > +static void
> > cpuidCall(virCPUx86CPUID *cpuid)
> > {
> > virHostCPUX86GetCPUID(cpuid->eax_in,
>
> Reviewed-by: Ján Tomko <jto...@redhat.com>
>
> Jano
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
