On Mon, Jun 16, 2025 at 10:45:15AM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik <mpriv...@redhat.com> > > In my previous commit of v11.0.0-rc1~115 I've made QEMU driver > implementation for virDomainGetXMLDesc() (qemuDomainGetXMLDesc()) > acquire QERY job. See its commit message for more info. But this > unfortunately broke apps witch fetch domain XML for incoming > migration (like virt-manager). The reason is that for incoming > migration the VIR_ASYNC_JOB_MIGRATION_IN async job is set, but > the mask of allowed synchronous jobs is empty (because QEMU can't > talk on monitor really). This makes virDomainObjBeginJob() fail > which in turn makes qemuDomainGetXMLDesc() fail too. > > It makes sense for qemuDomainGetXMLDesc() to acquire the job > (e.g. so that it's coherent with another thread that might be in > the middle of a MODIFY job). But failure to dump XML may be > treated as broken daemon (e.g. virt-manager does so). > > Therefore, still try to acquire the QUERY job (if job mask > permits it) but, do not treat failure as an error. > > Fixes: 6cc93bf28842526be2fd596a607ebca796b7fb2e > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2369243 > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > --- > src/qemu/qemu_driver.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Pavel Hrdina <phrd...@redhat.com>
signature.asc
Description: PGP signature
