On Wed, Jul 30, 2025 at 12:50:25PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 29, 2025 at 03:28:49PM -0600, Jim Fehlig wrote: > > > Andrea, > > > > > > Having spent a fair bit of time in the firmware auto-selection code, > > > perhaps you have an opinion about this? > > > > Sorry to keep nagging about this
No worries. The original message fell through the cracks somehow, so the ping is appreciated. > > I would need to install Fedora and verify myself, but I'd be surprised if it > > didn't encounter the same issue. Without the 'stateless' attribute, the > > following test would fail > > > > https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_firmware.c?ref_type=heads#L1303 > > > > executing the else condition, and failing similarly since the firmware is > > not split. > > So I've tested the scenario I mentioned before, and in fact see the > same behaviour as you describe > > error: operation failed: Unable to find 'efi' firmware that is compatible > with the current configuration > > which confuses me, because I'm sure I used virt-install to provision > SNP guests before, without expanding the args to > > --boot uefi,loader.stateless=on I can confirm that the issue reproduces on Fedora too, and that you've correctly identified the problem area. Patches hopefully addressing the issue are on the list now[1]. Thanks again for bringing this to my attention! [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/RKQ3ANKDNJEFJSKQR4FMDU7PVHWYKYSF/ -- Andrea Bolognani / Red Hat / Virtualization
