On Wed, Aug 20, 2025 at 08:24:51AM -0700, Andrea Bolognani wrote: > On Tue, Aug 19, 2025 at 04:09:28PM -0600, Jim Fehlig via Devel wrote: > > I will be off the remainder of the week, but can tidy the series and post a > > V1 next week if there's interest. > > AFAICT you've made no code change other than squashing in the fixup > that I had provided shortly after posting v1. Did I miss something? > > Your patch updating the SEV(-ES) tests to use q35 and UEFI looks > reasonable from a quick look. I'll take a closer one and report back. > > Overall it doesn't IMO make sense for you to post a series off that > branch. I can pick up your test suite changes, squash in my fix and > post v2 next week.
Done. https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/IBI4ZG6YDMW35WIEZVPHIQCVFZ5GMQZZ/ > > My WIP series drops the SEV features from the incompatible descriptors. > > That feels premature. I'm okay with going in that direction, but it's > not a change that we should make to the libvirt test suite before > reaching an agreement and having the change applied to the edk2 > package. The libvirt test suite is intended to match the real life > behavior as closely as possible. I just realized that one of the commits in my v2 pretty much matches this. Oops. Anyway I've marked it at DONOTMERGE because of the rationale above: we should never get ahead of the edk2 package, so that commit is just intended as a way to foster discussion. -- Andrea Bolognani / Red Hat / Virtualization
