Re: [PATCH v2 05/10] qemu: Fix matching for stateless/combined firmware

[Jim Fehlig via Devel]

On 8/25/25 10:19, Andrea Bolognani via Devel wrote:
The current code assumes that a stateless firmware has to be
explicitly requested by the user, and should never be picked
otherwise. This means that, for example, domains configured to
use SEV-SNP are forced to explicitly request for the firmware
to be stateless.

With proper firmware descriptors, I'd replace 'SEV-SNP' with 'SEV(-ES)'.


Additionally, we assume that only split firmware is suitable
for the stateful use case, whereas a combined firmware image
would also do the job.

As a result of these changes, the failing SEV-SNP test case
that was added recently passes, and so do the test cases
requesting read/write firmware.

Signed-off-by: Andrea Bolognani <abolo...@redhat.com>
---
  src/qemu/qemu_firmware.c                      | 40 ++++++++++++++-----

The code changes are fine IMO, and work in my testing.

  ...ware-auto-efi-rw-pflash.x86_64-latest.args | 36 +++++++++++++++++
  ...mware-auto-efi-rw-pflash.x86_64-latest.err |  1 -
  ...mware-auto-efi-rw-pflash.x86_64-latest.xml |  6 ++-
  .../firmware-auto-efi-rw.x86_64-latest.args   | 36 +++++++++++++++++
  .../firmware-auto-efi-rw.x86_64-latest.err    |  1 -
  .../firmware-auto-efi-rw.x86_64-latest.xml    |  6 ++-
  ...auto-efi-sev-snp.x86_64-latest+amdsev.args | 36 +++++++++++++++++
  ...-auto-efi-sev-snp.x86_64-latest+amdsev.err |  1 -
  ...-auto-efi-sev-snp.x86_64-latest+amdsev.xml |  6 ++-
  tests/qemuxmlconftest.c                       |  5 +--
  11 files changed, 154 insertions(+), 20 deletions(-)
  create mode 100644 
tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.args
  delete mode 100644 
tests/qemuxmlconfdata/firmware-auto-efi-rw-pflash.x86_64-latest.err
  create mode 100644 
tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.args
  delete mode 100644 
tests/qemuxmlconfdata/firmware-auto-efi-rw.x86_64-latest.err
  create mode 100644 
tests/qemuxmlconfdata/firmware-auto-efi-sev-snp.x86_64-latest+amdsev.args
  delete mode 100644 
tests/qemuxmlconfdata/firmware-auto-efi-sev-snp.x86_64-latest+amdsev.err

IMO, we should first agree on the firmware descriptor changes before 
tweaking/adding tests.

Regards,
Jim