On Fri, Sep 19, 2025 at 11:23:14AM +0200, Peter Krempa wrote:
> On Tue, Aug 19, 2025 at 18:22:31 +0200, Andrea Bolognani via Devel wrote:
> > + if (ARCH_IS_LOONGARCH(def->os.arch) ||
> > + qemuDomainIsRISCVVirt(def)) {
> > /* Use qemu-xhci (USB3) for modern architectures */
> > if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QEMU_XHCI))
> > return VIR_DOMAIN_CONTROLLER_MODEL_USB_QEMU_XHCI;
>
> As noted before this removes any fallback to the old controller; is that
> what you intended?
Yeah, a fallback on pci-ohci just doesn't make sense for recent
architectures such as riscv64 and loongarch64. But this change should
be spelled out explicitly in the commit message, just like the change
in the actual default is.
--
Andrea Bolognani / Red Hat / Virtualization
