On Tue, Nov 11, 2025 at 09:35:59AM +0100, Michal Prívozník via Devel wrote: > On 11/10/25 17:20, Peter Krempa via Devel wrote: > > From: Peter Krempa <[email protected]> > > > > 'libxml2' deprecated the 'xmlIndentTreeOutput' thread-local variable as > > well as the 'xmlThrDefIndentTreeOutput' function for setting the global > > default, which we use in our code for formatting the metadata sub-XML. > > > > 'libxml2' also for now doesn't provide a way to set target indentation > > level in 'xmlSaveCtxt' which would allow us to use the modern output > > APIs, we can't replace our use of 'xmlDumpNode'. > > Here, I'd like a reference to: > > https://gitlab.gnome.org/GNOME/libxml2/-/issues/989 > > > > > Since the indentation is enabled by default in libxml2 and most of our > > code using xmlDumpNode (notably except for the 'test' driver and > > embedded qemu driver uses) is in standalone processes, which didn't > > change the default, just removing the override will result in identical > > behaviour. > > I think there are more drivers like that: ESX, VMWare, hyperv and maybe > others.
IIUC, this problem only affects drivers which support the metadata XML, and none of those wire up the metadata support. $ git grep 'domainSetMetadata =' src/bhyve/bhyve_driver.c: .domainSetMetadata = bhyveDomainSetMetadata, /* 1.2.4 */ src/libxl/libxl_driver.c: .domainSetMetadata = libxlDomainSetMetadata, /* 5.7.0 */ src/lxc/lxc_driver.c: .domainSetMetadata = lxcDomainSetMetadata, /* 1.1.3 */ src/qemu/qemu_driver.c: .domainSetMetadata = qemuDomainSetMetadata, /* 0.9.10 */ src/remote/remote_driver.c: .domainSetMetadata = remoteDomainSetMetadata, /* 0.9.10 */ src/test/test_driver.c: .domainSetMetadata = testDomainSetMetadata, /* 1.1.3 */ With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
