On Wed, Nov 12, 2025 at 14:47:53 +0100, Hector Cao wrote: > Thanks Jiří for this feedback, much appreciated. > > To summarize the next steps: > > 1) I will submit a patch to modify the script sync_qemu_features_i386.py > The change aims to extract correctly the vmx-* features from the MSR > registers (and ONLY those MSR registers, other MSR registers > will be left untouched) that have > special logic (control bits in the 32 lower bits). > > 2) Once 1) has been approved and merged, > a) Run the script sync_qemu_features_i386.py to generate the x86 > feature XML file. > b) Run tests/cputestdata/cpu-data.py diff > tests/cputestdata/x86_64-cpuid-*.json > c) VIR_TEST_REGENERATE_OUTPUT=1 tests/cputest > Submit a patch with the change resulting from the above actions.
I suggest sending all this in a several patches in a single series (just make sure tests pass after each patch) as the changes to this script will be easier to review if we also see the result. Jirka
