On Thu, Nov 20, 2025 at 03:35:33PM +0100, Martin Kletzander wrote: > On Fri, Nov 07, 2025 at 02:13:52PM -0600, Praveen K Paladugu wrote: > > From: Praveen K Paladugu <[email protected]> > > > > This capability indicates if qemu supports mshv as an accelerator. Qemu > > with mshv capabilities can launch domains of type VIR_DOMAIN_VIRT_HYPERV. > > > > Signed-off-by: Praveen K Paladugu <[email protected]> > > --- > > src/qemu/qemu_capabilities.c | 1 + > > src/qemu/qemu_capabilities.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > > index 205bf3d0b8..c479a82473 100644 > > --- a/src/qemu/qemu_capabilities.c > > +++ b/src/qemu/qemu_capabilities.c > > @@ -748,6 +748,7 @@ VIR_ENUM_IMPL(virQEMUCaps, > > "acpi-generic-initiator", /* QEMU_CAPS_ACPI_GENERIC_INITIATOR > > */ > > "disk-timed-stats", /* QEMU_CAPS_DISK_TIMED_STATS */ > > "query-accelerators", /* QEMU_CAPS_QUERY_ACCELERATORS */ > > + "mshv", /* QEMU_CAPS_MSHV */ > > ); > > > > > > diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h > > index efbef2acef..2288db2b73 100644 > > --- a/src/qemu/qemu_capabilities.h > > +++ b/src/qemu/qemu_capabilities.h > > @@ -729,6 +729,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for > > syntax-check */ > > QEMU_CAPS_ACPI_GENERIC_INITIATOR, /* -object acpi-generic-initiator */ > > QEMU_CAPS_DISK_TIMED_STATS, /* timed stats support ('stats-intervals' > > property of disk frontends) */ > > QEMU_CAPS_QUERY_ACCELERATORS, /* query-accelerators command */ > > + QEMU_CAPS_MSHV, /* whether mshv is available */ > > it's nicer to show what the capability results in, so something like: > > QEMU_CAPS_MSHV, /* -accel mshv */ > > would be nicer. With that changed: > > Reviewed-by: Martin Kletzander <[email protected]>
Thanks Martin for the review. All the suggestions are minor. Do you (or other libvirt maintainers) expect us to resend? Or can those be taken care of while committing these patches? Wei > > > > > QEMU_CAPS_LAST /* this must always be the last item */ > > } virQEMUCapsFlags; > > -- > > 2.51.0 > >
