On Mon, Dec 29, 2025 at 12:40:23AM +0100, Andrea Bolognani via Devel wrote: > We will need to handle storage files using JSON format soon. > > Signed-off-by: Andrea Bolognani <[email protected]> > --- > src/conf/storage_source_conf.c | 2 +- > src/conf/storage_source_conf.h | 1 + > src/qemu/qemu_block.c | 2 ++ > tests/storagepoolcapsschemadata/poolcaps-fs.xml | 5 +++++ > tests/storagepoolcapsschemadata/poolcaps-full.xml | 5 +++++ > .../out/qcow2-qcow2_qcow2-qcow2_qcow2-auto | 2 +- > .../virstoragetestdata/out/qcow2-qcow2_qcow2-qcow2_raw-auto | 2 +- > tests/virstoragetestdata/out/qcow2-qcow2_qcow2-qcow2_raw-raw | 2 +- > tests/virstoragetestdata/out/qcow2-symlinks | 2 +- > .../out/qcow2datafile-qcow2_qcow2-datafile | 2 +- > 10 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/src/conf/storage_source_conf.c b/src/conf/storage_source_conf.c > index 087de1eaf2..e62707ba9b 100644 > --- a/src/conf/storage_source_conf.c > +++ b/src/conf/storage_source_conf.c > @@ -57,7 +57,7 @@ VIR_ENUM_IMPL(virStorageFileFormat, > "none", > "raw", "dir", "bochs", > "cloop", "dmg", "iso", > - "vpc", "vdi", > + "vpc", "vdi", "json", > /* Not direct file formats, but used for various drivers */ > "fat", "vhd", "ploop", > /* Formats with backing file below here */ > diff --git a/src/conf/storage_source_conf.h b/src/conf/storage_source_conf.h > index fc868b31af..0682da27f0 100644 > --- a/src/conf/storage_source_conf.h > +++ b/src/conf/storage_source_conf.h > @@ -63,6 +63,7 @@ typedef enum { > VIR_STORAGE_FILE_ISO, > VIR_STORAGE_FILE_VPC, > VIR_STORAGE_FILE_VDI, > + VIR_STORAGE_FILE_JSON,
I have the same comments as the previous patch, only it is even more critical here. 'json' is not a block device format. It is a config file format for the UEFI vars service, so it has no business being anywhere near the virStorageFileFormat code. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
