Re: [PATCH] Standardize socket family checks with proper macro

[Ján Tomko via Devel]

It would be sufficient to summarize this as:
    Standardize socket family checks

On a Tuesday in 2026, Julio Faracco wrote:

There is a macro

"The macro"

called

Unsure what purpose this word has in this sentence. What else would you
refer to a macro by if not by its name.

VIR_SOCKET_ADDR_IS_FAMILY that checks the socket
family.

I think it's named propely enough to not have to spell out its function.

There are several occurrences of raw checks in libvirt code.
This commit

just

I have no idea what this word is supposed to mean in this sentence.
It feels completely out of place.

Should this commit do something else? Is it not enough?
I don't think so, a commit should be some logically separate set of
changes. If there are more changes to do, they belong in a separate
commit.

standardizes the socket family checks by using its macro.

Whose macro?

Jano

Signed-off-by: Julio Faracco <jcfara...@gmail.com>
---

signature.asc
Description: PGP signature