Roman Bogorodskiy wrote: > The '-I' flag for enabling IOAPIC was deprecated long ago in bhyve: > > https://cgit.freebsd.org/src/commit/?id=a1a4cbea587a6e201e07dc121268f3e559e2969f > > And IOAPIC is provided unconditionally since then. As no supported > FreeBSD versions require that now, simply drop this flag. > > Signed-off-by: Roman Bogorodskiy <[email protected]> > --- > src/bhyve/bhyve_command.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c > index a45a5d1c33..97a483d9a5 100644 > --- a/src/bhyve/bhyve_command.c > +++ b/src/bhyve/bhyve_command.c > @@ -953,8 +953,6 @@ virBhyveProcessBuildBhyveCmd(struct _bhyveConn *driver, > virDomainDef *def, > /* Options */ > if (def->features[VIR_DOMAIN_FEATURE_ACPI] == VIR_TRISTATE_SWITCH_ON) > virCommandAddArg(cmd, "-A"); /* Create an ACPI table */ > - if (def->features[VIR_DOMAIN_FEATURE_APIC] == VIR_TRISTATE_SWITCH_ON) > - virCommandAddArg(cmd, "-I"); /* Present ioapic to the guest */ > if (def->features[VIR_DOMAIN_FEATURE_MSRS] == VIR_TRISTATE_SWITCH_ON) { > if (def->msrs_features[VIR_DOMAIN_MSRS_UNKNOWN] == > VIR_DOMAIN_MSRS_UNKNOWN_IGNORE) > virCommandAddArg(cmd, "-w"); > -- > 2.52.0 >
Bah, this commit misses this snippet: diff --git a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args index 146e3c6eee..a3d521069d 100644 --- a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args +++ b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-acpiapic.args @@ -2,7 +2,6 @@ bhyve \ -c 1 \ -m 214 \ -A \ --I \ -u \ -H \ -P \ And the 2/2 commit only removes the '-A' arg, not both.
