On Wed, Feb 11, 2026 at 06:36:06PM +0100, Erik Huelsmann wrote:
> Before this change, buffers returned from virFDStreamRead() would
> alternate in size (262120 and 24), because it only consumed the
> bytes remaining from the current background thread message.
> 
> As the background thread reads 262144 bytes (256kB) of data in
> each chunk, where the maximum size returned from virFDStreamRead()
> to be transferred over the remote protocol is only 262120, 24 bytes
> would be left in the buffer on each iteration. The next iteration
> leaves 24 bytes, which used to be returned without considering
> messages waiting in the queue.
> 
> Signed-off-by: Erik Huelsmann <[email protected]>
> ---
>  src/util/virfdstream.c | 26 +++++++++++++++++---------
>  1 file changed, 17 insertions(+), 9 deletions(-)

Reviewed-by: Daniel P. Berrangé <[email protected]>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Reply via email to