Daniel P. Berrangé <[email protected]> writes: > The vnc_display_print_local_addr() method is intended to print the VNC > listening address on the console at startup, so the user can see the > auto-chosen port address when using the 'to=' flag. This is only called > by vnc_display_open() which is in the QEMU startup callpath. The check > for not being in QMP is thus redundant and can be removed. > > Signed-off-by: Daniel P. Berrangé <[email protected]> > --- > ui/vnc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index 833e0e2e68..fe020dcc4c 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3578,9 +3578,9 @@ static void vnc_display_print_local_addr(VncDisplay *vd) > qapi_free_SocketAddress(addr); > return; > } > - error_printf_unless_qmp("VNC server running on %s:%s\n", > - addr->u.inet.host, > - addr->u.inet.port); > + error_printf("VNC server running on %s:%s\n", > + addr->u.inet.host, > + addr->u.inet.port); > qapi_free_SocketAddress(addr); > }
Reviewed-by: Markus Armbruster <[email protected]> Spotted in review: vnc_display_open() could be static. Observation, not a demand.
