On Wed, Feb 18, 2026 at 01:05:29PM +0100, Andrea Bolognani via Devel wrote: > This will be used to configure the backing storage used by the > uefi-vars QEMU device. > > Best viewed with 'git show -w'. > > Signed-off-by: Andrea Bolognani <[email protected]> > --- > src/conf/schemas/domaincommon.rng | 64 +++++++++++++++++++------------ > 1 file changed, 40 insertions(+), 24 deletions(-)
I'd expect this to be in the same commit that adds the parser code, along with matching docs, since you need to see all three pieces together from a review POV. > > diff --git a/src/conf/schemas/domaincommon.rng > b/src/conf/schemas/domaincommon.rng > index dafbdc63e7..e793bc5b1e 100644 > --- a/src/conf/schemas/domaincommon.rng > +++ b/src/conf/schemas/domaincommon.rng > @@ -349,31 +349,47 @@ > </element> > </optional> > <optional> > - <element name="nvram"> I'd suggest that first move this NVRAM <element> out into a <define name="osnvram"/>. The new element for vars can then also be its own define when adding the parsing code, and thus the <choice> content becomes short and readable. > - <optional> > - <attribute name="template"> > - <ref name="absFilePath"/> > - </attribute> > - </optional> > - <optional> > - <attribute name="templateFormat"> > - <ref name="pflashFormatTypes"/> > - </attribute> > - </optional> > - <optional> > - <ref name="pflashFormat"/> > - </optional> > - <optional> > - <choice> > - <group> > + <choice> > + <element name="nvram"> > + <optional> > + <attribute name="template"> > <ref name="absFilePath"/> > - </group> > - <group> > - <ref name="diskSource"/> > - </group> > - </choice> > - </optional> > - </element> > + </attribute> > + </optional> > + <optional> > + <attribute name="templateFormat"> > + <ref name="pflashFormatTypes"/> > + </attribute> > + </optional> > + <optional> > + <ref name="pflashFormat"/> > + </optional> > + <optional> > + <choice> > + <group> > + <ref name="absFilePath"/> > + </group> > + <group> > + <ref name="diskSource"/> > + </group> > + </choice> > + </optional> > + </element> > + <element name="varstore"> > + <interleave> > + <optional> > + <attribute name="template"> > + <ref name="absFilePath"/> > + </attribute> > + </optional> > + <optional> > + <attribute name="path"> > + <ref name="absFilePath"/> > + </attribute> > + </optional> > + </interleave> > + </element> > + </choice> > </optional> > <optional> > <ref name="osbootkernel"/> > -- > 2.53.0 > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
