On Thu, Feb 26, 2026 at 10:59:57 +0100, Pavel Hrdina via Devel wrote: > From: Pavel Hrdina <[email protected]> > > Reported-by: Peter Krempa <[email protected]> > Signed-off-by: Pavel Hrdina <[email protected]> > --- > src/qemu/qemu_hotplug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c > index bede4e3ccd..93cbaf1d91 100644 > --- a/src/qemu/qemu_hotplug.c > +++ b/src/qemu/qemu_hotplug.c > @@ -1680,8 +1680,10 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver, > qemuDomainObjExitMonitor(vm); > } > > + qemuDomainObjEnterMonitor(vm);
Ideally move ^^^ above the 'if (removeiommufd)' clause above and remove the monitor scope from that block. > qemuFDPassDirectTransferMonitorRollback(hostdevPriv->vfioDeviceFd, > priv->mon); > qemuFDPassDirectTransferMonitorRollback(priv->iommufd, priv->mon); > + qemuDomainObjExitMonitor(vm); With tthe above change: Reviewed-by: Peter Krempa <[email protected]>
