From: Peter Krempa <[email protected]>

Remove the extra temporary variable to make the changes in the next
patch more obvious.

Signed-off-by: Peter Krempa <[email protected]>
---
 src/qemu/qemu_hotplug.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index b3f2a173a8..6235f6c27c 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1134,20 +1134,19 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriver *driver,
                                virDomainObj *vm,
                                virDomainDeviceDef *dev)
 {
-    virDomainDiskDef *disk = dev->data.disk;
     virDomainDiskDef *orig_disk = NULL;

     /* this API overloads media change semantics on disk hotplug
      * for devices supporting media changes */
-    if ((disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ||
-         disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) &&
-        (orig_disk = virDomainDiskByTarget(vm->def, disk->dst))) {
+    if ((dev->data.disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ||
+         dev->data.disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) &&
+        (orig_disk = virDomainDiskByTarget(vm->def, dev->data.disk->dst))) {
         if (qemuDomainChangeEjectableMedia(driver, vm, orig_disk,
-                                           disk->src, false) < 0)
+                                           dev->data.disk->src, false) < 0)
             return -1;

-        disk->src = NULL;
-        virDomainDiskDefFree(disk);
+        dev->data.disk->src = NULL;
+        virDomainDiskDefFree(dev->data.disk);
         return 0;
     }

-- 
2.53.0

Reply via email to