On 4/22/26 16:14, marcandre.lureau--- via Devel wrote: > From: Marc-André Lureau <[email protected]> > > Hi, > > This series allows to run the QEMU VNC server in a standalone process. The > qemu-vnc binary is aimed to be released with QEMU 11.1. It is still being > reviewed > (https://patchew.org/QEMU/[email protected]/) > > The standalone VNC activates automatically when a domain has both <graphics > type='dbus'/> (bus mode) and <graphics type='vnc'/>, and the qemu-vnc binary > is > available. > > Comments welcome! > > Marc-André Lureau (6): > qemu: add standalone VNC state directory > qemu: add qemu-vnc configuration > qemu: add qemu-vnc helper unit > qemu: integrate standalone VNC in domain lifecycle > qemu: wire up standalone VNC in driver APIs > qemu: add tests for standalone VNC graphics > > po/POTFILES | 1 + > src/qemu/libvirtd_qemu.aug | 1 + > src/qemu/meson.build | 1 + > src/qemu/qemu.conf.in | 8 + > src/qemu/qemu_command.c | 2 + > src/qemu/qemu_conf.c | 8 + > src/qemu/qemu_conf.h | 2 + > src/qemu/qemu_domain.c | 1 + > src/qemu/qemu_domain.h | 2 + > src/qemu/qemu_driver.c | 68 ++- > src/qemu/qemu_extdevice.c | 13 +- > src/qemu/qemu_hotplug.c | 12 + > src/qemu/qemu_process.c | 40 +- > src/qemu/qemu_vnc.c | 407 ++++++++++++++++++ > src/qemu/qemu_vnc.h | 41 ++ > src/qemu/test_libvirtd_qemu.aug.in | 1 + > ...hics-vnc-standalone-p2p.x86_64-latest.args | 34 ++ > ...phics-vnc-standalone-p2p.x86_64-latest.xml | 40 ++ > .../graphics-vnc-standalone-p2p.xml | 39 ++ > ...s-vnc-standalone-socket.x86_64-latest.args | 33 ++ > ...cs-vnc-standalone-socket.x86_64-latest.xml | 40 ++ > .../graphics-vnc-standalone-socket.xml | 40 ++ > ...graphics-vnc-standalone.x86_64-latest.args | 33 ++ > .../graphics-vnc-standalone.x86_64-latest.xml | 40 ++ > .../graphics-vnc-standalone.xml | 40 ++ > tests/qemuxmlconftest.c | 4 + > tests/testutilsqemu.c | 9 + > 27 files changed, 950 insertions(+), 10 deletions(-) > create mode 100644 src/qemu/qemu_vnc.c > create mode 100644 src/qemu/qemu_vnc.h > create mode 100644 > tests/qemuxmlconfdata/graphics-vnc-standalone-p2p.x86_64-latest.args > create mode 100644 > tests/qemuxmlconfdata/graphics-vnc-standalone-p2p.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/graphics-vnc-standalone-p2p.xml > create mode 100644 > tests/qemuxmlconfdata/graphics-vnc-standalone-socket.x86_64-latest.args > create mode 100644 > tests/qemuxmlconfdata/graphics-vnc-standalone-socket.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/graphics-vnc-standalone-socket.xml > create mode 100644 > tests/qemuxmlconfdata/graphics-vnc-standalone.x86_64-latest.args > create mode 100644 > tests/qemuxmlconfdata/graphics-vnc-standalone.x86_64-latest.xml > create mode 100644 tests/qemuxmlconfdata/graphics-vnc-standalone.xml >
I'm fixing those trivial problems I've raised in my review and merging. Reviewed-by: Michal Privoznik <[email protected]> BUT, I'll be posting a follow up patches soon. Basically, upon libvirtd/virtqemud restart the vnc state (qemuVnc struct) is lost. I'll CC you on patches if you would like to take a look. Michal
