On 8/21/26 16:10, Roman Bogorodskiy wrote:
> Bhyve allows to set eui64 for the NVMe disks:
> 
>      eui64       IEEE Extended Unique Identifier (8 byte value).
> 
> And in a real command line:
> 
>  -s 5:0,nvme,/data/img/10gb.img,ser=BHYVE-NVME01-F000,eui64=0x01000000efbeadde
> 
> Model that using the <wwn> element:
> 
>   <disk type='file'>
>     <driver name='file' type='raw'/>
>     <source file='/path/to/some.img'/>
>     <target dev='nvme0n1' bus='nvme'/>
>     <wwn>01000000efbeadde</wwn>
>   </disk>
> 
> As this element does not allow commas, it's not necessary to add
> additional validation for that.
> 
> Closes: https://gitlab.com/libvirt/libvirt/-/work_items/901
> Signed-off-by: Roman Bogorodskiy <[email protected]>
> ---
> I think there's a bug in bhyve that results in a reversed order value,
> so I have to use "01000000efbeadde" to get "deadbeef00000001".
> I'm trying to address that in https://reviews.freebsd.org/D59080.
> 
>  src/bhyve/bhyve_command.c                                     | 4 ++++
>  .../x86_64/bhyvexml2argv-2-nvme-2-controllers.args            | 2 +-
>  .../x86_64/bhyvexml2argv-2-nvme-2-controllers.xml             | 1 +
>  .../x86_64/bhyvexml2argv-nvme-explicit-controller.args        | 2 +-
>  .../x86_64/bhyvexml2argv-nvme-explicit-controller.xml         | 1 +
>  .../x86_64/bhyvexml2xmlout-2-nvme-2-controllers.xml           | 1 +
>  .../x86_64/bhyvexml2xmlout-nvme-explicit-controller.xml       | 1 +
>  7 files changed, 10 insertions(+), 2 deletions(-)
> 

Reviewed-by: Michal Privoznik <[email protected]>

Michal

Reply via email to