On Tue, Aug 11, 2026 at 11:24:56AM +0200, Denis V. Lunev via Devel wrote:
> Switch max_size from virConfGetValueSizeT() to virConfGetValueBytes(),
> so it accepts "2MiB" the same way domain XML memory sizes do, instead
> of only a raw byte count.
> 
> virtlogd.aug accepts the quoted form too; its quoted branch requires a
> unit suffix, as one matching a bare number would overlap the integer
> branch.
> 
> Signed-off-by: Denis V. Lunev <[email protected]>
> ---
>  NEWS.rst                         | 5 +++++
>  src/logging/log_daemon_config.c  | 2 +-
>  src/logging/log_daemon_config.h  | 2 +-
>  src/logging/test_virtlogd.aug.in | 2 +-
>  src/logging/virtlogd.aug         | 5 ++++-
>  src/logging/virtlogd.conf        | 7 ++++++-
>  6 files changed, 18 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <[email protected]>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Reply via email to