On Thu, Oct 29, 2026 at 12:23:58AM +0100, Kevin Wolf wrote: > Commit a8686a9b, which made serial a qdev property instead of relying on > -drive options, accidentally allowed specifying serial strings of > arbitraty length while the virtio-blk protocol can only communicate 20 > characters to the guest. This means that a longer serial number on the > command line is silently truncated to 20 characters from the guest > perspective. > > This is obviously bad behaviour. People are specifying longer serials in > practice and guests will see something different than what was > configured. Instead of silent truncation, this should be an error. > > Deprecate the silent truncation for now as a first step towards making > it an error later. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > docs/about/deprecated.rst | 13 +++++++++++++ > hw/block/virtio-blk.c | 6 ++++++ > 2 files changed, 19 insertions(+)
Reviewed-by: Stefan Hajnoczi <[email protected]>
