Hi Daniel, > > > > At the time, I thought I saw patters where the following sequence > > > > might be going on: INIT -> START -> STEP -> START > > > Ah, if that's the case then my patch is incorrect, though the only thing > > > needed is to drop some checks to allow START after STEP again. I have > > > not seen that in my testing, though. And looking into remoteAuthSASL() I > > > don't see a way that a client could call the sequence from your example. > > > The only sequence possible is INIT -> START [-> STEP [-> STEP ...]]. > > Well, this line: > > https://gitlab.com/libvirt/libvirt/-/blob/master/src/remote/remote_driver.c?ref_type=heads#L3769 > > in combination with this "goto": > > https://gitlab.com/libvirt/libvirt/-/blob/master/src/remote/remote_driver.c?ref_type=heads#L3786 [...] > Ah, no, this is client side logic. [..] > IOW, we call start on the client library many times, but the > server only ever sees a single START rpc message.
Thanks! Good to have that cleared up! Then I guess that validates Michal's patch too. -- Bye, Erik. http://efficito.com -- Hosted accounting and ERP. Robust and Flexible. No vendor lock-in.
