On Mon, Nov 02, 2026 at 09:32:44 +0000, Abhisek Panda wrote:
> In the case of TLS-PSK-enabled migration, Libvirt manages the lifecycle
> of the pre-shared key. Add a new test scenario to the migration cookie
> test suite to validate the generation of pre-shared key when the
> QEMU_MIGRATION_COOKIE_TLS_PSK flag is set. In addition, the test also
> checks the length and the hexadecimal encoding of the pre-shared key.
> 
> Signed-off-by: Abhisek Panda <[email protected]>
> ---
>  tests/qemumigrationcookiexmltest.c | 123 +++++++++++++++++++++++++++++
>  tests/testutilsqemu.c              |  12 +++
>  2 files changed, 135 insertions(+)

All the code paths reporting error from testing should use
VIR_TEST_VERBOSE instead of VIR_TEST_DEBUG.

> diff --git a/tests/qemumigrationcookiexmltest.c 
> b/tests/qemumigrationcookiexmltest.c
> index 41846b8631..60ca62f98a 100644
> --- a/tests/qemumigrationcookiexmltest.c
> +++ b/tests/qemumigrationcookiexmltest.c
> @@ -16,6 +16,7 @@
>  
>  #include <config.h>
>  
> +#include <stddef.h>
>  #include <unistd.h>
>  
>  #include <sys/types.h>
> @@ -92,6 +93,99 @@ testQemuMigrationCookieDataFree(struct 
> testQemuMigrationCookieData *data)
>  }
>  
>  
> +static int
> +testQemuMigrationCookiePSKValidate(const char *key)
> +{
> +    g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(&driver);
> +    size_t expected_key_len = 2 * cfg->migrateTLSPSKLength; /* The 
> pre-shared key's length is 2 * PSK length */
> +    size_t i;
> +
> +    if (!key) {
> +        VIR_TEST_DEBUG("\nThe pre-shared key is not present in the migration 
> cookie.");
> +        return -1;
> +    }
> +
> +    if (strlen(key) != expected_key_len) {
> +        VIR_TEST_DEBUG("\nThe length of the pre-shared key is incorrect.");
> +        return -1;
> +    }
> +
> +    /* Check the characters of the key */
> +    for (i = 0; i < expected_key_len; i++) {
> +        if (!g_ascii_isxdigit(key[i])) {
> +            VIR_TEST_DEBUG("\nThe key contains non-hex characters");
> +            return -1;

This feels pointless. I'd suggest testing the actual key from the source
definition against the parsed one.

> +        }
> +    }
> +
> +    return 0;
> +}
> +
> +
> +static int
> +testQemuMigrationCookiePSKAttribute(const void *opaque)
> +{
> +    struct testQemuMigrationCookieData *data = (struct 
> testQemuMigrationCookieData *) opaque;
> +    g_autoptr(qemuMigrationCookie) cookie = NULL;
> +    qemuDomainObjPrivate *priv;
> +
> +    /* if the VM object parsing step failed there's nothing this test can do 
> */
> +    if (!data->vm) {
> +        VIR_TEST_DEBUG("\nmissing VM object\n");
> +        return -1;
> +    }
> +    priv = data->vm->privateData;
> +
> +    if (!(cookie = qemuMigrationCookieNew(data->vm->def, NULL)))
> +        return -1;
> +
> +    g_free(cookie->localHostname);
> +    cookie->localHostname = g_strdup("hostname2");
> +
> +    if (virUUIDParse("8b3f4dc4-6a8e-5f9b-94a5-4c35babd8d95", 
> cookie->localHostuuid) < 0) {
> +        VIR_TEST_DEBUG("\nfailed to parse fake UUID");
> +        return -1;
> +    }
> +
> +    /* Format the migration cookie at the source */
> +    if (qemuMigrationCookieFormat(cookie,
> +                                  &driver,
> +                                  data->vm,
> +                                  data->cookiePopulateParty,
> +                                  &data->xmlstr,
> +                                  &data->xmlstrlen,
> +                                  data->cookiePopulateFlags) < 0) {
> +        VIR_TEST_DEBUG("\nfailed to populate and format qemu migration 
> cookie");
> +        return -1;
> +    }
> +
> +    /* Check for the <migration-key> element in the generated migration 
> cookie XML */
> +    if (!strstr(data->xmlstr, "<migration-key>")) {
> +        VIR_TEST_DEBUG("\nthe migration cookie is missing the migration-key 
> element:\n%s\n",
> +                    data->xmlstr);
> +        return -1;

^^^ this case gets IMO sufficiently covered by the check below which
shows that the key was parsd properly.

> +    }
> +
> +    /* Parse the migration cookie at the destination */
> +    if (!(data->cookie = qemuMigrationCookieParse(&driver,
> +                                                  data->vm,
> +                                                  data->vm->def,
> +                                                  NULL,
> +                                                  priv->qemuCaps,
> +                                                  data->xmlstr,
> +                                                  data->xmlstrlen,
> +                                                  data->cookieParseFlags))) {
> +        VIR_TEST_DEBUG("\nfailed to parse qemu migration cookie:\n%s\n", 
> data->xmlstr);
> +        return -1;
> +    }
> +
> +    if (testQemuMigrationCookiePSKValidate(data->cookie->tlsPSK) < 0)
> +        return -1;
> +
> +    return 0;
> +}
> +
> +
>  static int
>  testQemuMigrationCookiePopulate(const void *opaque)
>  {

Reviewed-by: Peter Krempa <[email protected]>

Reply via email to