In the subject, should be VIR_DOMAIN_EVENT_STOPPED_REBOOT.
On 11/9/26 4:47 AM, Ben Grande wrote:
Signed-off-by: Ben Grande <[email protected]>
---
NEWS.rst | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 802f89190a..09ff7ef3e7 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -33,8 +33,20 @@ v12.10.0 (unreleased)
width reported to the guest. This allows the apparent bandwidth of a
passed-through device to match the host hardware.
+ * Introduce ``VIR_DOMAIN_EVENT_STOPPED_REBOOT`` event reason
Since the related enum is named 'virDomainEventStoppedDetailType', I'd use
'detail' instead of 'reason'.
+
+ Extract the shutdown reason from the hypervisor, and in case the domain
+ asked for reboot, the event ``VIR_DOMAIN_EVENT_STOPPED`` will have the
+ detail type ``VIR_DOMAIN_EVENT_STOPPED_REBOOT``.
This isn't true for all drivers, right? Looking at past news entries related to
events, I think it's enough mention the new event detail. What do you think of
something like:
A new ``VIR_DOMAIN_EVENT_STOPPED_REBOOT`` detail is now available for use with
the ``VIR_DOMAIN_EVENT_STOPPED`` lifecycle event. Drivers may use it to indicate
a domain has stopped as part of a reboot request.
+
* **Improvements**
+ * lxc: Report reboot reason ``VIR_DOMAIN_EVENT_STOPPED_REBOOT``.
+
+ * libxl: Report reboot reason ``VIR_DOMAIN_EVENT_STOPPED_REBOOT``.
+
+ * test driver: Report reboot reason ``VIR_DOMAIN_EVENT_STOPPED_REBOOT``.
These additions could be dropped IMO.
Regards,
Jim