Re: [M-Labs devel] [PATCH] Add Mimas V2 Spartan6 board to mibuild (http://numato.com/mimas-v2-spartan-6-fpga-development-board-with-ddr-sdram.html)

[Numato Sales]

Hi Sebastien/Tim,

Thanks for helpful pointers. I followed the directions as Tim suggested 
and sent out the patch using git send-mail. Also modified the script so 
it passes pep8 check now (command "pep8 mimasv2.py" reports no errors).

Thanks,
Tom

On 7/11/2015 8:24 PM, Tim Ansell wrote:
Hi Tom,

There are instructions in the misoc repo (see 
https://github.com/m-labs/misoc/blob/master/CONTRIBUTING.md) for using 
git-send-email to send patches to the mailing list. They also work 
with sending patches for migen too.

Tim 'mithro' Ansell



On 11 July 2015 at 18:56, Sebastien Bourdeauducq <s...@m-labs.hk 
<mailto:s...@m-labs.hk>> wrote:

    Hi Tom,

    thank you for your patch and good luck with your board project :)

    It mostly looks good, can you break lines in the source at 80
    characters and generally make the code PEP8-compliant (use e.g.
    flake8), and also prevent the word-wrap feature of your email
    client from corrupting your patch?
    (Sending it as am attachment would be a workaround)

    Regards,
    Sebastien

    _______________________________________________
    M-Labs devel mailing list
    https://ssl.serverraum.org/lists/listinfo/devel



_______________________________________________
M-Labs devel mailing list
https://ssl.serverraum.org/lists/listinfo/devel