Unsubscribe 

> On Dec 12, 2017, at 7:23 AM, Baptiste Gouraud <baptiste.gour...@unibas.ch> 
> wrote:
> 
> Here is a new version.
> 
> Baptiste
> ________________________________________
> From: Sébastien Bourdeauducq [s...@m-labs.hk]
> Sent: Tuesday, December 12, 2017 6:02 AM
> To: Baptiste Gouraud; devel@lists.m-labs.hk
> Subject: Re: [M-Labs devel] Signal(reset=-1)
> 
>> On Thursday, December 07, 2017 09:08 PM, Baptiste Gouraud wrote:
>> +def _truncate(value, nbits, signed):
> 
> If it is used across modules, it should have a better name and not be
> private (no '_').
> 
>>  _reserved_keywords = {
>>      "always", "and", "assign", "automatic", "begin", "buf", "bufif0", 
>> "bufif1",
>> @@ -43,11 +43,14 @@ def _printsig(ns, s):
>> 
>> 
>>  def _printconstant(node):
>> -    if node.signed:
>> -        return (str(node.nbits) + "'sd" + str(2**node.nbits + node.value),
>> -                True)
>> +    s = str(_truncate(node.value,node.nbits,node.signed))
> 
> Add spaces after commas.
> 
>> +    if node.signed:
>> +        if s[0] != '-':
> 
> No. Compare the value with 0.
> 
> Sébastien
> <0001-Verilog-backend-handles-out-of-range-values-for-cons.patch>
> _______________________________________________
> M-Labs devel mailing list
> https://ssl.serverraum.org/lists/listinfo/devel

_______________________________________________
M-Labs devel mailing list
https://ssl.serverraum.org/lists/listinfo/devel

Reply via email to