Hi,

* Remove curr_layout and input_update_keyboard_layout(), and call
sysconfig_get_keyboard_layout() in get_keycode().
* Rename MTK_KEY_MAX to MTK_KEY_INVALID (or any other name that clearly
means that this key code does not correspond to any key).
* To avoid potential namespace conflicts, use another identifier than
NIL, e.g. MTK_KEY_INVALID directly. You can #define NIL MTK_KEY_INVALID
in keymap.c as you did with the other keys, but do not define NIL in a
header.

Otherwise it's acceptable.

Thanks,
Sébastien

_______________________________________________
http://lists.milkymist.org/listinfo.cgi/devel-milkymist.org
IRC: #milkymist@Freenode
Twitter: www.twitter.com/milkymistvj
Ideas? http://milkymist.uservoice.com

Reply via email to